x86: Avoid dereference of 'struct page_info' for invalid MFNs.
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 19 Mar 2008 10:15:01 +0000 (10:15 +0000)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 19 Mar 2008 10:15:01 +0000 (10:15 +0000)
Introduced by my changes to Samuel's transitive-privilege patch.
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen/arch/x86/mm.c

index 5f8e2a8b7845d3775414033bef93c44cbe5ed6ad..bd92ec2f325ac75dd2c87fc28db3f07507c0f3e0 100644 (file)
@@ -645,7 +645,7 @@ get_page_from_l1e(
     struct page_info *page = mfn_to_page(mfn);
     uint32_t l1f = l1e_get_flags(l1e);
     struct vcpu *curr = current;
-    struct domain *owner = page_get_owner(page);
+    struct domain *owner;
     int okay;
 
     if ( !(l1f & _PAGE_PRESENT) )
@@ -680,6 +680,7 @@ get_page_from_l1e(
      * until pvfb supports granted mappings. At that time this minor hack
      * can go away.
      */
+    owner = page_get_owner(page);
     if ( unlikely(d != owner) && (owner != NULL) &&
          (d != curr->domain) && IS_PRIV_FOR(d, owner) )
         d = owner;